mrc-6151 get script and css from base url #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 183 183
Lines 4463 4463
Branches 990 988 -2
=======================================
Hits 4453 4453
Misses 9 9
Partials 1 1 ☔ View full report in Codecov by Sentry. |
M-Kusumgar
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy to epimodels with latest wodin main image is resulting in apps not rendering, because they are trying to fetch wodin.js and wodin.css from "/" rather than relative to baseUrl. This branch fixes this issue and is deployed to wodin-dev e.g. https://wodin-dev.dide.ic.ac.uk/msc-idm-2022/apps/heterogeneity-1
There's another issue, which is that a lot of the site index.html files are trying to use bootstrap.css from their site base url, which is not being found, resulting in unstyled pages e.g. https://wodin-dev.dide.ic.ac.uk/msc-idm-2022/ . I forget what we'd agreed to do there - did we say that sites ought to just use bootstrap themselves? Given that we'd like to redeploy this soon for the Royal Society app, and that we never got round to updating all the sites individually, we could just make bootstrap.css available again in the wodin container (temporarily...?) What do you think?